background doesn't turn green

Question

// delcare varaibles to prepare for other code
const body=document.body;
const input=document.querySelector("#number");
const submit=document.querySelector("button[type=submit]");
const randnum=Math.floor(Math.random()*10)+1;
// cheatcode
console.log(randnum);
//wait for user to submit
submit.addEventListener(
    'click', function correctornah(){
    if(parseInt(input)!== randnum){
        body.style.backgroundColor="#ed4337";
    }
    else if(parseInt(input)===randnum){
        body.style.backgroundColor="#37ed5e";
    }
});
this a code for a random number guesser website and when i put the correct number the background doesn't turn green.

Steven Parker · Accepted Answer

Since "input" is assigned to an HTML element, parseInt(input) will return NaN (not a number) which will never match a numeric value.
You probably meant to test the value entered instead (input.value).
Also, it's not necessary to test for the opposite of a condition, a plain else will do the same thing by itself.
In future postings containing code, please always use Markdown formatting (https://teamtreehouse.com/library/code) to preserve the code's appearance.  Also be sure to include the complete code, both the HTML and JavaScript parts (and perhaps CSS).  An easy way to share everything at once is to make a snapshot (https://teamtreehouse.com/library/previews-and-snapshots) of your workspace and post the link to it here.  And take a look at this video about Posting a Question (https://teamtreehouse.com/library/posting-a-question).

Welcome to the Treehouse Community

Looking to learn something new?

jason limmm

jason limmm

background doesn't turn green

1 Answer

Steven Parker

Steven Parker