Welcome to the Treehouse Community

Want to collaborate on code errors? Have bugs you need feedback on? Looking for an extra set of eyes on your latest project? Get support with fellow developers, designers, and programmers of all backgrounds and skill levels here with the Treehouse Community! While you're at it, check out some resources Treehouse students have shared here.

Looking to learn something new?

Treehouse offers a seven day free trial for new students. Get access to thousands of hours of content and join thousands of Treehouse students and alumni in the community today.

Start your free trial

JavaScript Build a Simple Dynamic Site with Node.js Creating a Basic Template Engine in Node.js A Simple Merge Utility

John Stegman
John Stegman
12,182 Points

Build a Simple Dynamic Site with Node.js - Code Challenge

Can't seem to get this to work - works OK on my console

function merge(content, values) { for(var key in values) { content = content.replace("%first_name%", values[key]); } return content; } module.exports.merge = merge;

2 Answers

function merge(content, values) {
  for(var key in values) { 
    content = content.replace("%" + key + "%", values[key]); 
  }
  return content;
}


module.exports.merge = merge;

The challenge asks you to write a function that replaces all the keys in the content, not only the first_name...
P.S Just finished it a couple of hours ago; it's a tough course.

Richard Rowland
Richard Rowland
16,574 Points

Thanks for that answer Yuval, I had completely missed the point about it being all keys, I've just spent 15 minutes trying to work out what was wrong before a google search led me here.