Welcome to the Treehouse Community

Want to collaborate on code errors? Have bugs you need feedback on? Looking for an extra set of eyes on your latest project? Get support with fellow developers, designers, and programmers of all backgrounds and skill levels here with the Treehouse Community! While you're at it, check out some resources Treehouse students have shared here.

Looking to learn something new?

Treehouse offers a seven day free trial for new students. Get access to thousands of hours of content and join thousands of Treehouse students and alumni in the community today.

Start your free trial

JavaScript Build a Simple Dynamic Site with Node.js Creating a Basic Template Engine in Node.js A Simple Merge Utility

Posted by Jimmy Stafford
Jimmy Stafford
Courses Plus Student 11,998 Points

Challenge Task 1

Unsure if my values[key] reference is wrong or if there are other problems as well.

index.js 
var utilities = require("./utilities");

var mailValues = {};

mailValues.first_name = "Janet";

var emailTemplate = "Hi %first_name%! Thanks for completing this code challenge :)";

var mergedContent = utilities.merge(emailTemplate, mailValues);

//mergedContent === "Hi Janet! Thanks for completing this code challenge :)";
utilities.js 
function merge(content, values) {
  for(var key in values) {
    content = content.replace("%first_name%", values[key]);
  }
  return content;
}


module.exports.merge = merge;

2 Answers

Tobias Helmrich
Tobias Helmrich
31,603 Points
Tobias Helmrich
Tobias Helmrich
31,603 Points

Hey Jimmy,

your value[keys] reference is correct and I think your code should work like this. However you should dynamically replace the key between the % symbols. Right now you're hardcoding it with "%first_name%", so it would only work with this particular key. If you use the key instead of writing "first_name" directly it should work.

Like so:

function merge(content, values) {
  for(var key in values) {
    content = content.replace("%" + key + "%", values[key]);
  }
  return content;
}


module.exports.merge = merge;

Good luck! :)

Jimmy Stafford
PLUS
Jimmy Stafford
Courses Plus Student 11,998 Points
Jimmy Stafford
Jimmy Stafford
Courses Plus Student 11,998 Points

Thanks. I was so dead set on the second parameter being incorrect. I didn't bother to consider the first parameter.