Welcome to the Treehouse Community

Want to collaborate on code errors? Have bugs you need feedback on? Looking for an extra set of eyes on your latest project? Get support with fellow developers, designers, and programmers of all backgrounds and skill levels here with the Treehouse Community! While you're at it, check out some resources Treehouse students have shared here.

Looking to learn something new?

Treehouse offers a seven day free trial for new students. Get access to thousands of hours of content and join thousands of Treehouse students and alumni in the community today.

Start your free trial

Python Python Basics (2015) Letter Game App Letter Game Introduction

Kevin Lopez
Kevin Lopez
1,019 Points
Posted by Kevin Lopez
Kevin Lopez
1,019 Points

Code Not Working

FOR SOME REASON THIS CODE IS NOT WORKING. EVERYTHING WORKS FINE EXCEPT WHEN I GUESS THE WORD. ONCE I GUESS THE WORD IT DOESNT PRINT OUT THAT I WIN WHICH IS WHATS SUPPOSED TO HAPPEN. PLEASE HELP

import random
#make a list of words
words = [
    'barcelona',
    'paris',
    'bayern',
    'manchester',
    'madrid',
    'dormund',
    'orlando',
    'chelsea',
    'arsenal',
    'valencia',
    'lester'
]

while True:
    start = input("Press enter / return to start, or enter Q to quit ")
    if start.lower() == 'q':
        break
    #pick a random word 
    secret_word = random.choice(words)
    bad_guesses = []
    good_guesses = []

    while len(bad_guesses) < 7 and len(good_guesses) != len(list(secret_word)):
        #draw spaces 
        #draw guessed letters and strikes
        for letter in secret_word:
            if letter in good_guesses:
                print(letter, end='')
            else:
                print('_', end = '')
        print('')
        print('Strikes: {}/7'.format(len(bad_guesses)))
        print('')

        #take guess
        guess = input("Guess a letter. ").lower()

        if len(guess) != 1:
          print("You can only guess a single letter!")
          continue
        elif guess in bad_guesses or guess in good_guesses:
            print("You've already guessed that letter!")
            continue
        elif not guess.isalpha():
            print("You can only guess letters!")
            continue

        if guess in secret_word:
          good_guesses.append(guess)
          if len(good_guesses) == len(secret_word):
              print("You winn! The word was {}".format(secret_word))
              break
        else:
          bad_guesses.append(guess)



    else:
          print("You didn't guess it! My secret word was {}".format(secret_word))



    #draw guessed letters and strikes
    # print out win/lose

1 Answer

Steven Parker
Steven Parker
231,271 Points
Steven Parker
Steven Parker
231,271 Points

:point_right: It looks like you need a new win-checking method.

It seems that you are comparing the number of good guesses to the number of letters in the word, which will work if the word has no duplicate letters (like "paris").

But a word like "madrid" has 6 letters but only 5 guesses are needed, so the values won't match.

Rethink the checking strategy and alter the program to perform it.

Iain Simmons
Iain Simmons
Treehouse Moderator 32,305 Points

I don't think this would have been covered in the course yet, but Kevin Lopez could use a set and compare its length to the number of good guesses, since it would only contain unique/non-duplicate values.

Kevin Lopez
Kevin Lopez
1,019 Points
Kevin Lopez
Kevin Lopez
1,019 Points

thank you for your help. this is my new code now

import random
#make a list of words
words = [
    'barcelona',
    'paris',
    'bayern',
    'manchester',
    'madrid',
    'dormund',
    'orlando',
    'chelsea',
    'arsenal',
    'valencia',
    'lester'
]
def get_not_repeated_characters(secret_word):
  result = []
  for letter in secret_word:
    if not letter in result:
        result.append(letter)
  return result


while True:
    start = input("Press enter / return to start, or enter Q to quit ")
    if start.lower() == 'q':
        break
    #pick a random word 
    secret_word = random.choice(words)
    secret_characters = get_not_repeated_characters(secret_word)
    length_secreat_characters = len(secret_characters)
    bad_guesses = []
    good_guesses = []

    while len(bad_guesses) < 7 and len(good_guesses) != len(list(secret_word)):
        #draw spaces 
        #draw guessed letters and strikes
        for letter in secret_word:
            if letter in good_guesses:
                print(letter, end='')
            else:
                print('_', end = '')
        print('')
        print('Strikes: {}/7'.format(len(bad_guesses)))
        print('')

        #take guess
        guess = input("Guess a letter. ").lower()

        if len(guess) != 1:
          print("You can only guess a single letter!")
          continue
        elif guess in bad_guesses or guess in good_guesses:
            print("You've already guessed that letter!")
            continue
        elif not guess.isalpha():
            print("You can only guess letters!")
            continue

        if guess in secret_word:
          good_guesses.append(guess)
          if len(good_guesses) == length_secreat_characters:
              print("You winn! The word was {}".format(secret_word))
              break
        else:
          bad_guesses.append(guess)



    else:
          print("You didn't guess it! My secret word was {}".format(secret_word))



    #draw guessed letters and strikes
    # print out win/lose