Welcome to the Treehouse Community

Want to collaborate on code errors? Have bugs you need feedback on? Looking for an extra set of eyes on your latest project? Get support with fellow developers, designers, and programmers of all backgrounds and skill levels here with the Treehouse Community! While you're at it, check out some resources Treehouse students have shared here.

Looking to learn something new?

Treehouse offers a seven day free trial for new students. Get access to thousands of hours of content and join thousands of Treehouse students and alumni in the community today.

Start your free trial

Python Object-Oriented Python Dice Roller RPG Roller

Posted by peter xiao
peter xiao
2,626 Points

Couldn't import `Hand`

I do not know why my codes got error. The codes work well in my pydev.

class Hand(list): def init(self, size=0, die_class=D20): super().init() for _ in range(size): self.append(die_class())

@classmethod
def roll(cls, size):
    return cls(size=size)

@property
def total(self):
    total=0
    for i in self:
        total += i
    return total

hands = Hand.roll(2) hands.total

dice.py 
import random

class Die:
    def __init__(self, sides=2):
        if sides < 2:
            raise ValueError("Can't have fewer than two sides")
        self.sides = sides
        self.value = random.randint(1, sides)

    def __int__(self):
        return self.value

    def __add__(self, other):
        return int(self) + other

    def __radd__(self, other):
        return self + other

class D20(Die):
    def __init__(self):
        super().__init__(20)
hands.py 
import list
from dice import D20

class Hand(list):
    def __init__(self, size, die_class):
        super().__init__()
        for _ in range(size):
            self.append(die_class())

    @classmethod
    def roll(cls, size):
        return cls(size=size, die_class=D20)

    @property
    def total(self):
        sum=0
        for i in self:
            sum += i
        return sum

hands = Hand.roll(2)
hands.total

2 Answers

peter xiao
peter xiao
2,626 Points

clean the codes, and still got " Bummer! Try again!" for the following code

class Hand(list): @property def total(self): return sum(self)

def __init__(self, size=0, die_class=None):
    if not die_class:
        raise ValueError("You must provide a die class")
    super().__init__()

    for _ in range(size):
        self.append(die_class())

@classmethod
def roll(cls, size):
    return cls(size=size, die_class=D20)
Steven Parker
Steven Parker
231,248 Points
Steven Parker
Steven Parker
231,248 Points

You "cleaned" a bit too much, you need to put this back in: "from dice import D20".

Steven Parker
Steven Parker
231,248 Points
Steven Parker
Steven Parker
231,248 Points

You're almost there.

  • don't import "list", it's a built-in
  • just define "Hand", don't call it yourself (the challenge does that)

Also, your "total" method is good, but you didn't need to replace it. In general, you should do only what the challenge asks but nothing extra. That "extra" stuff might work in the IDE but can throw the challenge.