Welcome to the Treehouse Community

Want to collaborate on code errors? Have bugs you need feedback on? Looking for an extra set of eyes on your latest project? Get support with fellow developers, designers, and programmers of all backgrounds and skill levels here with the Treehouse Community! While you're at it, check out some resources Treehouse students have shared here.

Looking to learn something new?

Treehouse offers a seven day free trial for new students. Get access to thousands of hours of content and join thousands of Treehouse students and alumni in the community today.

Start your free trial

JavaScript Build a Simple Dynamic Site with Node.js Creating a Basic Template Engine in Node.js A Simple Merge Utility

Deano k
PLUS
Deano k
Courses Plus Student 5,872 Points
Posted by Deano k
Deano k
Courses Plus Student 5,872 Points

How to solve this challange

Can't really solve this chalange, not sure what the issue is

index.js 
var utilities = require("./utilities");

var mailValues = {};

mailValues.first_name = "Janet";

var emailTemplate = "Hi %first_name%! Thanks for completing this code challenge :)";

var mergedContent = utilities.merge(emailTemplate, mailValues);

//mergedContent === "Hi Janet! Thanks for completing this code challenge :)";
utilities.js 
function merge(content, values) {
  for (var key in values) {
  content.replace('%' + key + '%', values.key);
  }
  return content;

}


module.exports.merge = merge;

2 Answers

Steven Parker
Steven Parker
231,248 Points
Steven Parker
Steven Parker
231,248 Points

You're close. But if you attach ".key" to values, it's going to try to get an item that has the key name of "key". You need to use key as an index.

Also, replace doesn't change the source, so you have to assign the result back to the source for the change to stick.

So you want something like this:

  content = content.replace('%' + key + '%', values[key]);