Welcome to the Treehouse Community

Want to collaborate on code errors? Have bugs you need feedback on? Looking for an extra set of eyes on your latest project? Get support with fellow developers, designers, and programmers of all backgrounds and skill levels here with the Treehouse Community! While you're at it, check out some resources Treehouse students have shared here.

Looking to learn something new?

Treehouse offers a seven day free trial for new students. Get access to thousands of hours of content and join thousands of Treehouse students and alumni in the community today.

Start your free trial

JavaScript JavaScript Basics (Retired) Creating Reusable Code with Functions Create a max() Function

Posted by Robin Porter
Robin Porter
1,810 Points

I keep getting the bummer

Apparently, something is very wrong with my code. Can you please review it and see if you see the error?

script.js 
function max (n1, n2) {
 var bigger = n1 > n2; 
}
 if (n1 > n2); {
    return n1;
  } else (n1 < n2);
    return n2;
}

1 Answer

Steven Parker
Steven Parker
231,271 Points
Steven Parker
Steven Parker
231,271 Points

You're getting close, but:

  • you don't need to create the "bigger" variable
  • the closing brace for the function should go after the conditional code
  • a final "else" does not take (or need) a conditional expression