Welcome to the Treehouse Community

Want to collaborate on code errors? Have bugs you need feedback on? Looking for an extra set of eyes on your latest project? Get support with fellow developers, designers, and programmers of all backgrounds and skill levels here with the Treehouse Community! While you're at it, check out some resources Treehouse students have shared here.

Looking to learn something new?

Treehouse offers a seven day free trial for new students. Get access to thousands of hours of content and join thousands of Treehouse students and alumni in the community today.

Start your free trial

Python

Posted by Julian Gu
Julian Gu
12,490 Points

Not sure why this doesn't work

I have tested this in the python shell and it works just fine, and the values are correct as well.

product.py 
class Product:
    _price = 0.0
    tax_rate = 0.12

    def __init__(self, base_price):
        self._price = base_price

    @property
    def price(self):
        return self._price + (self._price * self.tax_rate)

    @price.setter
    def price(self, price):
        self._price = price / (1 + self.tax_rate)

1 Answer

Krishna Pratap Chouhan
Krishna Pratap Chouhan
15,203 Points

You just have to set the price with the new price. Dont have to do all those calculation.

See the code for better understanding.

class Product:
    _price = 0.0
    tax_rate = 0.12

    def __init__(self, base_price):
        self._price = base_price

    @property
    def price(self):
        return self._price + (self._price * self.tax_rate)

    @price.setter
    def price(self, price):
        self._price = price
Greg Kaleka
Greg Kaleka
39,021 Points
Greg Kaleka
Greg Kaleka
39,021 Points

This passes, but that means the code challenge is wrong. This is not the right way to actually do what you want to do. The price property is meant to reflect the total price with tax (which is why it returns self._price + (self._price * self.tax_rate). Therefore when you set the total price, you need to set the _price attribute correctly, taking tax into account, which is what Julian did correctly.

Kenneth Love, I was tripped up by this, and if you look at the number of questions around this challenge that have the same solution, it's tripping up a lot of people.