Welcome to the Treehouse Community

Want to collaborate on code errors? Have bugs you need feedback on? Looking for an extra set of eyes on your latest project? Get support with fellow developers, designers, and programmers of all backgrounds and skill levels here with the Treehouse Community! While you're at it, check out some resources Treehouse students have shared here.

Looking to learn something new?

Treehouse offers a seven day free trial for new students. Get access to thousands of hours of content and join thousands of Treehouse students and alumni in the community today.

Start your free trial

JavaScript Build a Simple Dynamic Site with Node.js Creating a Basic Template Engine in Node.js A Simple Merge Utility

Leo Marco Corpuz
Leo Marco Corpuz
18,975 Points
Posted by Leo Marco Corpuz
Leo Marco Corpuz
18,975 Points

Quiz after the binding values tutorial

Is anything missing in my code? I'm still not clear about how to use the % placeholders in my code.

index.js 
var utilities = require("./utilities");

var mailValues = {};

mailValues.first_name = "Janet";

var emailTemplate = "Hi %first_name%! Thanks for completing this code challenge :)";

var mergedContent = utilities.merge(emailTemplate, mailValues);

//mergedContent === "Hi Janet! Thanks for completing this code challenge :)";
utilities.js 
function merge(content, values) {
    for(var key in values){
    content.replace(key,values[key])

    };
  return content;
}


module.exports.merge = merge;

1 Answer

Steven Parker
Steven Parker
231,248 Points
Steven Parker
Steven Parker
231,248 Points

You're pretty close. But remember that you don't just want to replace the key, but the key and the percent signs surrounding it.

Also, the "replace" method doesn't change the string you apply it to, it returns a new string with the changes. So you'll want to save that somewhere.

Leo Marco Corpuz
Leo Marco Corpuz
18,975 Points
Leo Marco Corpuz
Leo Marco Corpuz
18,975 Points

I think I've fixed it. function merge(content, values) { for(var key in values){ var newContent= content.replace("%" + key + "%",values[key]) }; return newContent; } module.exports.merge = merge;

Steven Parker
Steven Parker
231,248 Points
Steven Parker
Steven Parker
231,248 Points

Apparently the challenge only tests using an object with a single property, and this does pass. :+1:

But to be able to handle objects with more properties, you'd probably want to re-use the "content" variable instead of creating a new one.