Welcome to the Treehouse Community

Want to collaborate on code errors? Have bugs you need feedback on? Looking for an extra set of eyes on your latest project? Get support with fellow developers, designers, and programmers of all backgrounds and skill levels here with the Treehouse Community! While you're at it, check out some resources Treehouse students have shared here.

Looking to learn something new?

Treehouse offers a seven day free trial for new students. Get access to thousands of hours of content and join thousands of Treehouse students and alumni in the community today.

Start your free trial

JavaScript

Ismael Sandoval
seal-mask
.a{fill-rule:evenodd;}techdegree
Ismael Sandoval
Full Stack JavaScript Techdegree Student 1,797 Points
Posted by Ismael Sandoval
.a{fill-rule:evenodd;}techdegree
Ismael Sandoval
Full Stack JavaScript Techdegree Student 1,797 Points

Refactor Code solution

let html = ' ';
let randomRGB;
let redBlueGreenRandom = () => Math.floor(Math.random() * 256);


for (let i = 1; i <= 10; i++) {
  randomRGB = `rgb( ${redBlueGreenRandom()}, ${redBlueGreenRandom()}, ${redBlueGreenRandom()} )`;
  html += `<div style="background-color: ${randomRGB}">${i}</div>`;
} 

document.querySelector('main').innerHTML = html;

2 Answers

Steven Parker
Steven Parker
240,995 Points
Steven Parker
Steven Parker
240,995 Points

You don't need to declare randomRGB in the global scope. Just put "let" in front of the assignment in the loop.

Interesting coincidence that you and Matthew Lane made very similar posts at about the same time.

Steven Parker
Steven Parker
240,995 Points
Steven Parker
Steven Parker
240,995 Points

I see you made the redBlueGreenRandom function local to the loop, which is also good scoping. What I was suggesting was moving randomRGB into the loop. Plus, they can both be const. Doing all 3 would look like this:

let html = '';

for (let i = 1; i <= 10; i++) {
  const redBlueGreenRandom = () => Math.floor(Math.random() * 256);
  const randomRGB = `rgb( ${redBlueGreenRandom()}, ${redBlueGreenRandom()}, ${redBlueGreenRandom()} )`;
  html += `<div style="background-color: ${randomRGB}">${i}</div>`;
} 

document.querySelector('main').innerHTML = html;
Ismael Sandoval
seal-mask
.a{fill-rule:evenodd;}techdegree
Ismael Sandoval
Full Stack JavaScript Techdegree Student 1,797 Points
Ismael Sandoval
.a{fill-rule:evenodd;}techdegree
Ismael Sandoval
Full Stack JavaScript Techdegree Student 1,797 Points

Thanks for the feedback, would it be like this?

let html = '';
let randomRGB;


for (let i = 1; i <= 10; i++) {
  let redBlueGreenRandom = () => Math.floor(Math.random() * 256);
  randomRGB = `rgb( ${redBlueGreenRandom()}, ${redBlueGreenRandom()}, ${redBlueGreenRandom()} )`;
  html += `<div style="background-color: ${randomRGB}">${i}</div>`;
} 

document.querySelector('main').innerHTML = html;