Still getting "expected undefined to be false" for checkForShip even after following all the instructions in the video

What seems to be the problem, at least for me in this step, was that an empty array wasn't actually evaluating as 'false'. So in our

if (!shipPresent)

Could read

if(shipPresent.length <= 0)

and we'll be working again.

Could it be that 'player' is not defined with the var keyword, making it a global variable, thus out of scope of the test block?

I have followed the video to the tee and I still can't get the test to pass

test returns:

1) checkForShip should correctly report no ship at a given players coordinate:
     AssertionError: expected undefined to be false
      at Context.<anonymous> (test/ship_test.js:16:46)

my files are:

ship_test.js

var expect = require('chai').expect;

describe('checkForShip', function() {
  var checkForShip = require('../game_logic/ship_methods.js').checkForShip;

  it('should correctly report no ship at a given players coordinate',function() {

    var player = {
      ships: [
        {
          locations: [[0, 0]]
        }
      ]
    };

    expect(checkForShip(player, [9,9])).to.be.false;
  });

});

ship_methods.js

function checkForShip(player, coordinates) {
  var shipPresent, ship;

  for (var i = 0; i < player.ships.length; i++) {
    ship = player.ships[i];

    shipPresent = ship.locations.filter(function(actualCoordinate) {
      return (actualCoordinate[0] === coordinates[0]) && (actualCoordinate[1] === coordinates[1]);
    })[0];
    if (!shipPresent) {
      return false;
    }
  }
}

module.exports.checkForShip = checkForShip;

This is my solution. I'm using a second Array.forEach loop instead of Array.filter because (spoiler alert) you're going to refactor this function to return an object instead of a boolean in a few videos:

ship_test.js:
Passes all tests, including tests for multiple ships and locations.

const expect = require('chai').expect;

describe('checkForShip', () => {
  const checkForShip = require('../game_logic/ship_methods').checkForShip;
  const player1 = { ships: [{ locations: [[0, 0]] }] };
  it('should correctly report no ship at a given player\'s coordinate', () => {
    expect(checkForShip(player1, [1, 1])).to.be.false;
  });
});

ship_methods.js:
Returns a boolean for now...

const checkForShip = (player, coords) => {
  let result;
  player.ships.forEach((item) => {
    item.locations.forEach((coord) => {
      if ((coord[0] === coords[0]) && (coord[1] === coords[1])) {
        result = item;
      }
    });
  });
  return typeof result === 'object';
};

When you get to the part of the course where you need to return an object, simply change the return statement to return result || false; and you'll either return an object if there was a hit, or false if there was a miss.

If anyone is getting expected undefined to be false while using forEach instead of a for loop, I believe it's because forEach returns undefined. A for...of loop works, though! Hope that helps someone!

ship_test.js

const {expect} = require('chai');

describe('checkForShip', () => {
  const {checkForShip} = require('../game_logic/ship_methods');
  it('should correctly report no ship at a given player\'s coordinate', () => {
    const player = {
      ships: [
        {
          locations: [[0, 0]]
        }
      ]
    };
    expect(checkForShip(player, [9, 9])).to.be.false;
  });
});

ship_methods.js

function checkForShip(player, guess) {
  let shipPresent;
  for (ship of player.ships) {
    shipPresent = ship.locations.filter((coords) => {
      return (coords[0] === guess[0]) && (coords[1] === guess[1]);
    })[0];
    if (!shipPresent) {
      return false;
    }
  }
}

module.exports.checkForShip = checkForShip;