Welcome to the Treehouse Community

Want to collaborate on code errors? Have bugs you need feedback on? Looking for an extra set of eyes on your latest project? Get support with fellow developers, designers, and programmers of all backgrounds and skill levels here with the Treehouse Community! While you're at it, check out some resources Treehouse students have shared here.

Looking to learn something new?

Treehouse offers a seven day free trial for new students. Get access to thousands of hours of content and join thousands of Treehouse students and alumni in the community today.

Start your free trial

Python

Posted by Jorleni Maldonado
Jorleni Maldonado
14,398 Points

What am I doing wrong in my code?

Please help

hands.py 
from dice import D6


class Hand(list):
    def __init__(self, size=0, die_class=None, *args, **kwargs):
        if not die_class:
            raise ValueError("You must provide a die class")
        super().__init__()

        for _ in range(size):
            self.append(die_class())
        self.sort()

    def _by_value(self, value):
        dice = []
        for die in self:
            if die == value:
                dice.append(die)
        return dice


class CapitalismHand(Hand):
    def __init__(self, *args, **kwargs):
        super().__init__(size=2, die_class=D6, *args, **kwargs)

   @property
    def doubles(self):
        return self[0] == self[1]
    for num in self._sets.values():
        if num > 1:
    return  True
    return  False

    @property
    def ones(self):
        return self._by_value(1)

    @property
    def twos(self):
        return self._by_value(2)

    @property
    def threes(self):
        return self._by_value(3)

    @property
    def fours(self):
        return self._by_value(4)

    @property
    def fives(self):
        return self._by_value(5)

    @property
    def sixes(self):
        return self._by_value(6)

    @property
    def _sets(self):
        return {
            1: len(self.ones),
            2: len(self.twos),
            3: len(self.threes),
            4: len(self.fours),
            5: len(self.fives),
            6: len(self.sixes)
        }
Jorleni Maldonado
Jorleni Maldonado
14,398 Points

This is the challenge question...

Alright! Now I need you to add a new property called doubles. It should return True if both of the dice have the same value. Otherwise, return False.

1 Answer

Alex Koumparos
seal-mask
.a{fill-rule:evenodd;}techdegree
Alex Koumparos
Python Development Techdegree Student 36,887 Points
Alex Koumparos
.a{fill-rule:evenodd;}techdegree
Alex Koumparos
Python Development Techdegree Student 36,887 Points

Hi Jorleni,

Your problem is the code that starts with

for  num in self._sets.values():

This for loop is scoped to the root level of the class, which is invalid. I'm going to assume you meant for it to be part of the method that it immediately follows. If this is the case, you would need to have the block indented to the same level as the preceding line (return self[0] == self[1]).

However, this code would never be executed because your method will return before it even gets to the for loop (in the line return self[0] == self[1] your method is going to exit, either returning True or returning False).

Your return True and return False lines also have incorrect indentation.

Note however, that your method is completely functional with just the line return self[0] == self[1] and that is all that is required to pass the challenge.

Hope that clears things up for you

Cheers

Alex

Jorleni Maldonado
Jorleni Maldonado
14,398 Points

That worked, I was overthinking it. Thank you :)