Welcome to the Treehouse Community

Want to collaborate on code errors? Have bugs you need feedback on? Looking for an extra set of eyes on your latest project? Get support with fellow developers, designers, and programmers of all backgrounds and skill levels here with the Treehouse Community! While you're at it, check out some resources Treehouse students have shared here.

Looking to learn something new?

Treehouse offers a seven day free trial for new students. Get access to thousands of hours of content and join thousands of Treehouse students and alumni in the community today.

Start your free trial

JavaScript Build a Simple Dynamic Site with Node.js Creating a Basic Template Engine in Node.js A Simple Merge Utility

Sevcan ALKAN
PLUS
Sevcan ALKAN
Courses Plus Student 1,207 Points
Posted by Sevcan ALKAN
Sevcan ALKAN
Courses Plus Student 1,207 Points

What the problem?

The problem is where? looks like the code runs. Where I'm doing wrong.

index.js 
var utilities = require("./utilities");

var mailValues = {};

mailValues.first_name = "Janet";

var emailTemplate = "Hi %first_name%! Thanks for completing this code challenge :)";

var mergedContent = utilities.merge(emailTemplate, mailValues);

//mergedContent === "Hi Janet! Thanks for completing this code challenge :)";
utilities.js 
function merge(content, values) {
  for(var key in values){
    content= content.replace("%"+key+"%",values.key);
  }

  return content;
}


module.exports.merge = merge;
Ali Amirazizi
Ali Amirazizi
16,087 Points
Ali Amirazizi
Ali Amirazizi
16,087 Points

I checked the validator and it return these suggestions. 

/*
Index.js:
Number/Line/Character/Description
1   1   17  'require' was used before it was defined.
var utilities = require("./utilities");

utilities.js 
Number/Line/Character/Description
1   2   3   Missing 'use strict' statement.
for(var key in values){
2   2   6   Missing space between 'for' and '('.
for(var key in values){
3   2   7   Move 'var' declarations to the top of the function.
for(var key in values){
4   2   7   Stopping. (20% scanned).
*/

1 Answer

Sevcan ALKAN
PLUS
Sevcan ALKAN
Courses Plus Student 1,207 Points
Sevcan ALKAN
Sevcan ALKAN
Courses Plus Student 1,207 Points

ok I address the problem, utilities.js in ;
"content= content.replace("%"+key+"%",values.key);" I changed as: "content= content.replace("%"+key+"%",values[key]);". I tried to access the object in the wrong way, Thanks.